feat: hide internal information in case of error #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Chenebault <benjamin.chenebault@keeneye.tech>
|
Hi! Thanks for the suggestion! |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Hi Alexis, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, your plugin displays the error message returned by the go library when it fails to reach the modsecurity container.
This approach is interesting for debugging and it facilitates the setup of the plugin.
However, it also reveals information about the internal architecture that should remain hidden.
As an example, the message below reveals that I'm using kubernetes, that my modsecurity pod is deployed in my kube-system namespace, and that my CIDR looks like 172.20.X.X
By reading the source code of traefik and some other plugins, I see that it is more common to log the information and return only an HTTP error code without details.
So I propose a very simple modification here and I open the discussion.
Thanks in advance and thx for your time.
Signed-off-by: Benjamin Chenebault benjamin.chenebault@gmail.com