frameReaderTime giving wrong timestamps

[noughtmare]

frameReaderTime is giving the wrong timestamps for some H.264 videos. I think this is the case because it is getting the time_base from the AVCodecContext. The time_base of the AVStream seems to give me the correct values. Is there a way to fix this?

[acowley]

Probably! I'm not at a computer right now, but if you can see where to pull it out of the stream, I'd be happy to accept a fix!

[noughtmare]

I would export the AVStream in the findVideoStream function.
The type of the function findVideoStream would then become:

findVideoStream :: (MonadIO m, MonadError String m) => AVFormat -> m (CInt, AVCodecContext, AVCodec, AVStream)

Then the AVStream can be used instead of the AVCodecContext to find the numerator and denominator of the inverse framerate. like this:

AVRational num den <- liftIO $ getTimeBase vidStream

[acowley]

@noughtmare Can you check that the StreamTime branch addresses the issue you encountered?

[noughtmare]

Yes, that solves the issue.