Acpica trivial #196
Merged
Acpica trivial #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
You had better do this quickly, release will be this Thursday, Friday at the very latest
*
*
*
* acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file
What is this?
* Utilities: Add ACPI_DO_ONCE macros
What is this?
* Dispatcher: Introduce timeout mechanism for infinite loop detection
Not an emergency since we have already introduced a workaround for now.
From: zetalog [mailto:notifications@github.com]
Sent: Monday, December 19, 2016 11:48 PM
To: acpica/acpica <acpica@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [acpica/acpica] Acpica trivial (#196)
Before releasing 201612xx, maybe we can have something in this pull request merged.
Let me send it here to have it reviewed.
I'm enhancing these patches these days.
Thanks
Lv
…________________________________
You can view, comment on, or merge this pull request online at:
#196
Commit Summary
* acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file
* Utilities: Add ACPI_DO_ONCE macros
* Dispatcher: Introduce timeout mechanism for infinite loop detection
File Changes
* M source/components/dispatcher/dscontrol.c<https://github.com/acpica/acpica/pull/196/files#diff-0> (24)
* M source/components/tables/tbxfload.c<https://github.com/acpica/acpica/pull/196/files#diff-1> (5)
* M source/components/utilities/utinit.c<https://github.com/acpica/acpica/pull/196/files#diff-2> (8)
* M source/include/acconfig.h<https://github.com/acpica/acpica/pull/196/files#diff-3> (4)
* M source/include/acglobal.h<https://github.com/acpica/acpica/pull/196/files#diff-4> (1)
* M source/include/aclocal.h<https://github.com/acpica/acpica/pull/196/files#diff-5> (1)
* M source/include/acmacros.h<https://github.com/acpica/acpica/pull/196/files#diff-6> (5)
* M source/include/acoutput.h<https://github.com/acpica/acpica/pull/196/files#diff-7> (7)
* M source/include/acpixf.h<https://github.com/acpica/acpica/pull/196/files#diff-8> (15)
* M source/include/actypes.h<https://github.com/acpica/acpica/pull/196/files#diff-9> (2)
* M source/include/platform/acgcc.h<https://github.com/acpica/acpica/pull/196/files#diff-10> (15)
* M source/include/platform/aclinux.h<https://github.com/acpica/acpica/pull/196/files#diff-11> (5)
* M source/tools/acpiexec/aetables.c<https://github.com/acpica/acpica/pull/196/files#diff-12> (1)
Patch Links:
* https://github.com/acpica/acpica/pull/196.patch
* https://github.com/acpica/acpica/pull/196.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#196>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA6_rOV9xKpx7lMwukzMIAojwibB4niKks5rJ4g-gaJpZM4LRjco>.
|
|
Hi, Bob
From: Robert Moore [mailto:notifications@github.com]
Sent: Wednesday, December 21, 2016 12:10 AM
To: acpica/acpica <acpica@noreply.github.com>
Cc: Zheng, Lv <lv.zheng@intel.com>; Author <author@noreply.github.com>
Subject: Re: [acpica/acpica] Acpica trivial (#196)
You had better do this quickly, release will be this Thursday, Friday at the very latest
*
*
*
* acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file
What is this?
To Eliminate some “#ifdef”.
* Utilities: Add ACPI_DO_ONCE macros
What is this?
Requested by a developer.
They want to shrink ACPICA evaluation failure messages.
When something is wrong, this fills up their /var/log disk.
So implement print_once like macro for them.
Since this is useless for non-developers.
I made it a compile-time feature.
* Dispatcher: Introduce timeout mechanism for infinite loop detection
Not an emergency since we have already introduced a workaround for now.
OK,
Removing it.
One more commit added
5e64857fe829
Thanks
Lv
From: zetalog [mailto:notifications@github.com]
Sent: Monday, December 19, 2016 11:48 PM
To: acpica/acpica <acpica@noreply.github.com<mailto:acpica@noreply.github.com>>
Cc: Subscribed <subscribed@noreply.github.com<mailto:subscribed@noreply.github.com>>
Subject: [acpica/acpica] Acpica trivial (#196)
Before releasing 201612xx, maybe we can have something in this pull request merged.
Let me send it here to have it reviewed.
I'm enhancing these patches these days.
Thanks
Lv
…________________________________
You can view, comment on, or merge this pull request online at:
#196
Commit Summary
* acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file
* Utilities: Add ACPI_DO_ONCE macros
* Dispatcher: Introduce timeout mechanism for infinite loop detection
File Changes
* M source/components/dispatcher/dscontrol.c<https://github.com/acpica/acpica/pull/196/files#diff-0> (24)
* M source/components/tables/tbxfload.c<https://github.com/acpica/acpica/pull/196/files#diff-1> (5)
* M source/components/utilities/utinit.c<https://github.com/acpica/acpica/pull/196/files#diff-2> (8)
* M source/include/acconfig.h<https://github.com/acpica/acpica/pull/196/files#diff-3> (4)
* M source/include/acglobal.h<https://github.com/acpica/acpica/pull/196/files#diff-4> (1)
* M source/include/aclocal.h<https://github.com/acpica/acpica/pull/196/files#diff-5> (1)
* M source/include/acmacros.h<https://github.com/acpica/acpica/pull/196/files#diff-6> (5)
* M source/include/acoutput.h<https://github.com/acpica/acpica/pull/196/files#diff-7> (7)
* M source/include/acpixf.h<https://github.com/acpica/acpica/pull/196/files#diff-8> (15)
* M source/include/actypes.h<https://github.com/acpica/acpica/pull/196/files#diff-9> (2)
* M source/include/platform/acgcc.h<https://github.com/acpica/acpica/pull/196/files#diff-10> (15)
* M source/include/platform/aclinux.h<https://github.com/acpica/acpica/pull/196/files#diff-11> (5)
* M source/tools/acpiexec/aetables.c<https://github.com/acpica/acpica/pull/196/files#diff-12> (1)
Patch Links:
* https://github.com/acpica/acpica/pull/196.patch
* https://github.com/acpica/acpica/pull/196.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#196>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA6_rOV9xKpx7lMwukzMIAojwibB4niKks5rJ4g-gaJpZM4LRjco>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#196 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADcsFZ5ttslNoZWyyFmKDZOZbTMcqzdrks5rJ_3NgaJpZM4LRjco>.
|
zetalog
force-pushed
the
acpica-trivial
branch
from
5e64857
to
bcaf75d
Compare
|
Hi, Bob Pull request refreshed. Thanks |
zetalog
force-pushed
the
acpica-trivial
branch
3 times, most recently
from
a2727bd
to
d8d9842
Compare
This adds the missing ACPI_PRINTF_LIKE attribute which allows compile time format string checking (and will be used by the coming initify gcc plugin). Additionally, this fixes the warnings exposed by the attribute. Original by Emese Revfy and Kees Cook, Ported by Lv Zheng. Signed-off-by: Emese Revfy <re.emese@gmail.com> Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Lv Zheng <lv.zheng@intel.com>
…cific file The new line is only useful for acpiexec, so moving it to acpiexec to eliminate the #ifdef. Signed-off-by: Lv Zheng <lv.zheng@intel.com> --
This patch implements ACPI_DO_ONCE macros to avoid log floodings. There could be OSPM gaps causing some ACPICA functionalities continously reporting errors, filling up users' filesystem. Reported by Aaron Franke, Fixed by Lv Zheng. Link: https://bugzilla.kernel.org/show_bug.cgi?id=188331 Reported-by: Aaron Franke <arnfranke@yahoo.com> Signed-off-by: Lv Zheng <lv.zheng@intel.com>
zetalog
force-pushed
the
acpica-trivial
branch
from
d8d9842
to
93d652b
Compare
|
This pull request only contains community materials. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before releasing 201612xx, maybe we can have something in this pull request merged.
Let me send it here to have it reviewed.
I'm enhancing these patches these days.
Thanks
Lv