Fix for github issue 659 #663
Conversation
This change prepares ExInsertArgCount so that a function that searches the AslGbl_ExternalList can be extracted. Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
|
First, thanks for the PR and for your time and dedication However, I compiled the latest binaries with this PR merged and the issue persists. |
|
@1alessandro1 could you post the file that exhibits this issue? I tried to compile the tables posted by @foskvs in the issues page but I'm not seeing the compiler error. |
|
I was a little confused by what @foskvs said but I see the compiler error now. I've fixed the compiler so that it can allow iASL to compile, disassemble, and recompile the code in question. However, if you're doing the disassembly and re-compilation on tables that have been initially compiled other than this version of the compiler, then you'll still get the error because the external method declarations have been omitted in the initial compilation. |
At the moment, the external analysis walk attempts to optimize the size
of AML by removing external method declarations that are not called.
This results in the external declaration in the following code being
removed during compilation:
External (EXT0, MethodObj) // EXT0 removed during compilation
if (!CondRefOf (EXT0))
{
Method (EXT0)
{
...
}
}
This happens because referencing externals inside of CondRefOf is not a
method call. This results in the first line being removed during
compilation and breaks the re-compilation of the above code after
disassembly. In order to retain the external declaration, change the
external method analysis to look for any named referenced in addition to
method calls.
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
|
@SchmErik Please test this (compile, no errors, then decompile, and recompile) |
|
ah, I made a slight mistake and I fixed it just now. Could you try fetching and re-compiling? I force-pushed so you might need to do something like git reset --hard |
|
perfect, the issue is gone |
This reverts commit 52a8236, reversing changes made to 79acf21. This pull request was intended to resolve a bug in the compiler but further exposed a different bug in the compiler. Revert the material from this pull request for now in order to diagnost the issue. It would be nice to come up with solutions that simplify the logic in iASL's external analysis. Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
Revert "Merge pull request acpica#663 from SchmErik/ghi-659"
Revert "Merge pull request #663 from SchmErik/ghi-659"
This pull request contains fixes for github issue 659 by changing iASL behavior to keep external methods that are referenced in iASL constructs such as
if (CondRefOf (EXT0))