Constify AcpiGetHandle pathname argument #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AcpiGetHandle doesn't write to the pathname argument, therefore make it const. This allows later on passing pathname to AcpiGetHandle which is const, without creating a copy of it. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
rafaeljw
approved these changes
May 17, 2022
|
I'm worried that there are lots of these sprinkled throughout ACPICA - and this fix could open the door to lots of changes. |
|
Hi Robert,
On Thu, Aug 18, 2022 at 09:15:14AM -0700, Robert Moore wrote:
I'm worried that there are lots of these sprinkled throughout ACPICA - and
this fix could open the door to lots of changes.
Could you elaborate your concern a little? Is it that there are other
functions that do not write to the data behind a pointer taken as an
argument which could be const but is not, or something else? Const is being
used in acpica already, albeit perhaps not everywhere it could be.
The alternatives for this change are making the large data structure (a
single memory allocation) not const or allocating a temporary buffer for
the path name, checking the allocation succeeded and finally copying the
const pathname there before calling the function.
Both are poor workarounds compared to fixing the root issue.
…--
Regards,
Sakari Ailus
|
|
Ping.
|
Do you think that people will try to annotate pathname pointers all over with const? Or something else? |
|
From: Rafael J. Wysocki ***@***.***>
Sent: Thursday, October 13, 2022 10:16 AM
To: acpica/acpica ***@***.***>
Cc: Moore, Robert ***@***.***>; Comment ***@***.***>
Subject: Re: [acpica/acpica] Constify AcpiGetHandle pathname argument (PR #773)
I'm worried that there are lots of these sprinkled throughout ACPICA - and this fix could open the door to lots of changes.
Do you think that people will try to annotate pathname pointers all over with const? Or something else?
Yes, that might be the case. However, I was thinking about other external interfaces to ACPICA that have similar pointers.
—
Reply to this email directly, view it on GitHub<#773 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHL7LDOZWXOOCAOU26FDLDWDA7WHANCNFSM5VHZSQVA>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
|
|
I don't see a problem with AcpiGetHandle() in particular TBH and the other cases can be considered individually IMO. |
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this pull request
Dec 20, 2022
acpi_get_handle() uses the pathname argument to find a handle related to that pathname but it does not need to modify it. Make it const, in order to be able to pass const pathname to it. Cc: "Moore, Robert" <robert.moore@intel.com> Link: acpica/acpica#773 Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request contains a single patch, constifying the pathname argument to AcpiGetHandle. The objective is to allow passing a const pathname to the function, in order to avoid having to make a copy of it. This isn't needed by acpica per se, but by another caller in Linux.
It's the first time I'm using Github to do this, let's see how this works...