Detect FACS even for reduced hardware platforms #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nit: |
The FACS is optional even on hardware reduced platforms, and may exist for the purpose of communicating the hardware_signature field to provoke a clean reboot instead of a resume from hibernation. Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
dwmw2
force-pushed
the
reduced-hardware-facs
branch
from
ffd58ed
to
44fc328
Compare
|
Hi David, I will need to check and confirm if this PR can possibly go against the ACPI (6.5) Specification or not since usually there is a good reason for prior design decisions made by previous (or even current) ACPICA maintainers! Also please confirm in the meantime that whatever you tried works fine on reduced hardware or if it still is under test, thanks a lot! |
|
Hi Saket, Yes, it's tested on Arm64 in conjunction with https://lore.kernel.org/lkml/20240312134148.727454-2-dwmw2@infradead.org/#t (and tianocore/edk2@ba96acd to make UEFI actually expose the FACS). |
rafaeljw
approved these changes
Apr 10, 2024
|
Thanks a lot for this contribution, LGTM now! |
shaoyingxu
pushed a commit
to amazonlinux/linux
that referenced
this pull request
Apr 19, 2024
ACPICA PR acpica/acpica#933 The FACS is optional even on hardware reduced platforms, and may exist for the purpose of communicating the hardware_signature field to provoke a clean reboot instead of a resume from hibernation. Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
shaoyingxu
pushed a commit
to amazonlinux/linux
that referenced
this pull request
Apr 22, 2024
ACPICA PR acpica/acpica#933 The FACS is optional even on hardware reduced platforms, and may exist for the purpose of communicating the hardware_signature field to provoke a clean reboot instead of a resume from hibernation. Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
shaoyingxu
pushed a commit
to amazonlinux/linux
that referenced
this pull request
Apr 24, 2024
ACPICA PR acpica/acpica#933 The FACS is optional even on hardware reduced platforms, and may exist for the purpose of communicating the hardware_signature field to provoke a clean reboot instead of a resume from hibernation. Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
puranjaymohan
pushed a commit
to amazonlinux/linux
that referenced
this pull request
May 3, 2024
ACPICA PR acpica/acpica#933 The FACS is optional even on hardware reduced platforms, and may exist for the purpose of communicating the hardware_signature field to provoke a clean reboot instead of a resume from hibernation. Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
shaoyingxu
pushed a commit
to amazonlinux/linux
that referenced
this pull request
May 3, 2024
ACPICA PR acpica/acpica#933 The FACS is optional even on hardware reduced platforms, and may exist for the purpose of communicating the hardware_signature field to provoke a clean reboot instead of a resume from hibernation. Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
puranjaymohan
pushed a commit
to amazonlinux/linux
that referenced
this pull request
May 6, 2024
ACPICA PR acpica/acpica#933 The FACS is optional even on hardware reduced platforms, and may exist for the purpose of communicating the hardware_signature field to provoke a clean reboot instead of a resume from hibernation. Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
puranjaymohan
pushed a commit
to amazonlinux/linux
that referenced
this pull request
May 7, 2024
ACPICA PR acpica/acpica#933 The FACS is optional even on hardware reduced platforms, and may exist for the purpose of communicating the hardware_signature field to provoke a clean reboot instead of a resume from hibernation. Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FACS is optional even on hardware reduced platforms, and may exist for the purpose of communicating the hardware_signature field to provke a clean reboot instead of a resume from hibernation.