Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Move the creds.json file parsing to the CloudEnvironment component #42

Closed
cpliakas opened this issue Mar 9, 2014 · 4 comments
Closed
Milestone

Comments

@cpliakas
Copy link
Contributor

cpliakas commented Mar 9, 2014

The creds.json file also contains the info for the memcache servers, so it seems like the Cloud Environment class is a good place to store the credential parsing code since it is environment specific and can be reused.

@cpliakas cpliakas added this to the 0.10.0 milestone Mar 9, 2014
@timhilliard
Copy link

@cpliakas we are looking to deprecate creds.json in favour of config.json. Both files contain the same information and are in the same folder but we would prefer config.json to be used as it is more representative of the content of the file.

@cpliakas
Copy link
Contributor Author

@timhilliard, good to know, thanks! Would be great to maintain a grace period of one or two hosting releases where creds.json links to config.json once the change happens. I know there are people not using the SDK who have this hard-coded, so I want to make sure they have time to transition.

@timhilliard
Copy link

There are no plans to remove it anytime soon so you don't have to worry. We
just may not add extra functionality to it. That will go into config.json.

On Sun, Mar 16, 2014 at 11:06 PM, Chris Pliakas notifications@github.comwrote:

@timhilliard https://github.com/timhilliard, good to know, thanks!
Would be great to maintain a grace period of one or two hosting releases
where creds.json links to config.json once the change happens. I know there
are people not using the SDK who have this hard-coded, so I want to make
sure they have time to transition.

Reply to this email directly or view it on GitHubhttps://github.com//issues/42#issuecomment-37756559
.

Tim Hilliard

Cloud Hosting Engineer | Acquia http://acquia.com/

tim.hilliard@acquia.com | @big_bear84 https://twitter.com/big_bear84

@cpliakas
Copy link
Contributor Author

cpliakas commented Apr 1, 2014

Added issue to track "credentials" vs "config" nomenclature change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants