Replace abandoned composer package 'webmozart/path-util' #4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkorik
changed the title
danepowell
requested changes
Mar 22, 2023
|
Unfortunately, I don't think we can do this until Drupal 9 is EOL, since Drupal 9 requires Symfony 4 and the path utilities were only added to Symfony 5. |
|
We are about a week away from D9 EOL, could this PR now be revisited/reopened/recreated? https://www.drupal.org/about/core/policies/core-release-cycles/schedule |
|
Yes, we will revisit this in the near future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4669 . As outlined in the projects deprecation notice this should be replaced with the symfony filesystem component.
Proposed changes
Replaces the method used from the
Pathutility fromwebmozart/path-utilwith a replacement method from thesymfony/filesystemcomponent. Removes the composer direct dependency on the abandoned project.Testing steps
Ensure the
blt internal:add-to-projectcommand successfully adds custom blt related files to the expected.gitignorefile within the configured projectrepo.rootdirectory.