Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLT-5224: Add back PHP code sniffing in pre-commit hook #4701

Closed
brunodbo opened this issue Sep 22, 2023 · 2 comments
Closed

BLT-5224: Add back PHP code sniffing in pre-commit hook #4701

brunodbo opened this issue Sep 22, 2023 · 2 comments
Labels
Enhancement A feature or feature request

Comments

@brunodbo
Copy link

PHP code sniffing was removed from the pre-commit hook in 552ff15. Would it be possible to add it back? Unless there is a reason not to - it's unclear why it was removed, there is no issue referenced on the commit.
@brunodbo brunodbo added the Enhancement A feature or feature request label Sep 22, 2023
@github-actions github-actions bot changed the title Add back PHP code sniffing in pre-commit hook BLT-5224: Add back PHP code sniffing in pre-commit hook Sep 22, 2023
brunodbo added a commit to brunodbo/blt that referenced this issue Sep 22, 2023
@brunodbo
acquia#4701: Add back PHP code sniffing in pre-commit hook
0e51b3e
@danepowell
Copy link
Contributor

Code sniffing was moved to a plugin, which is why it can't be part of the core commit hook: https://github.com/acquia/blt-phpcs

@brunodbo
Copy link
Author

@danepowell That makes sense, closing this issue and associated PR. Thanks for the insight!

@brunodbo brunodbo mentioned this issue Oct 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement A feature or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brunodbo @danepowell