BLT 92 Backported Functionality #3284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l memcache module. (acquia#3058) (acquia#3067) * Require drupa/memcache equal or greater than 2.0-alpha7. * Updating memcache settings based on change in drupal/memcache module.
* Finished updating memcache config for alpha7. * Locking drupal/memcache to 2.0-alpha7 until memcache stabilizes.
* Start memcached service and add php extension. * Check status of memcached service. * Use blt memcache config on CI.
Correcting links to PHPStorm documentation on Acquia's documentation service.
* VM setup tips (acquia#3036) * Update local-development.md to reference committing DrupalVM files. * New guidelines for contribution. (acquia#3045) * Adding replication and verification step sections and clean up formatting. * Adding new guidelines for PRs to the CONTRIBUTING docs. * Fixes acquia#2964: When manually deploying using a tag also push that tag to source repo. (acquia#2992) * Adding a cutSourceTag method and invoking when deploying tag. * Set default deploy.tag_source config setting and check it when deploying. * Refactoring to use a single cutTag method. * Remove line about expectation you already have a tag on your source before you tag a release. * Warn if user is creating a tag but tag_source option is false. * Updating deploy documentation.
…king core dev dependencies. (acquia#3068)
Fixed minor typo in code review docs.
…ia#2994) (acquia#3105) Force-approving this based on the same code's approval on the 9.x branch.
…2946) * Fixes acquia#2945: removing exception for cloud hooks on ACSF. * Cleaning up variable use in db scrub hook. * Adding ACSF check to post deploy and makes db scrub consistent with others.
* Refactor post-install hook to use temp cache dir per site, use requests instead of ENV. * Refresh Factory Hooks from template for 9002001. * Update version number for hook. * Remove redundant factory hook update. * Removed unused use statements. * Style and phpcs updates.
* Fix auto detection of sites dir due to core changes. * Update proxy and host detection for core updates and Acquia VCL changes. * PHPCS fixes.
The Acquia docs link pointed to a stale page and the BLT one pointed to the 8.x branch, both throwing 404's. I've updated both to point to the latest iterations of each page.
Fixes acquia#2289 -------- Changes proposed: --------- (What are you proposing we change?) - Update composer contraint on Drupal Coder newest release (8.3.1 as of this date) - Update composer constraint on squizlabs/php_codesniffer to 3.0.1 (matching Coder) - Remove the use of a bootstrap file with PHPCS. File paths that are not allowed by filesets won't be sniffed by default. - Add a tests:phpcs:sniff:modified command to sniff unstaged modified or added files in repo for convenience.
* Fix comment formatting in PhpUnitCommand. (acquia#3211) * Fixes acquia#3063 by updating faq and install docs to improve install profile instructions. (acquia#3064) * [9.2.x] Fix undefined trusted_reverse_proxy_ips acquia#3214 (acquia#3215) Fixes acquia#3214 -------- Changes proposed: --------- (What are you proposing we change?) - check if trusted_reverse_proxy_ips is defined as an array - if not, set an empty array Steps to replicate the issue: ---------- (If this PR is not fixing a defect/bug, you can remove this section.) 1. blt setup 2. bootstrap drupal Steps to verify the solution: ----------- (How does someone verify that this does what you think does?) 1. apply the patch 2. blt setup / bootstrap Drupal 3. check to ensure following warning does not appear: ``` Warning: in_array() expects parameter 2 to be array, null given in require() (line 27 of /app/vendor/acquia/blt/settings/blt.settings.php). require('/app/vendor/acquia/blt/settings/blt.settings.php') (Line: 806) require('/app/docroot/sites/naswa_main/settings.php') (Line: 125) Drupal\Core\Site\Settings::initialize('/app/docroot', 'sites/naswa_main', Object) (Line: 1056) Drupal\Core\DrupalKernel->initializeSettings(Object) (Line: 655) Drupal\Core\DrupalKernel->handle(Object) (Line: 19) ``` * Fixes acquia#3185 to bring install and local docs inline. (acquia#3186) * Fixing updates 9002000 message. (acquia#3205) * Fixing missing semi-colon at end of line. (acquia#3208) * Fixes acquia#3243 to clean up dry-run in deploy command. (acquia#3263) * Multisite bugfixes (acquia#3231) * Fix multisite test alias bug. * Fix default drush local multisite alias bug causing test failures. * Fix global varible scope and phpcs syntax. * Update variable names and fix phpcs validation errors..
|
It seems like we might want to reduce the scope of this. The initial intention was just to backport functionality around site factory hooks, right? |
|
Looks like a Behat failure:
Maybe removing the Behat changes would resolve? |
grasmash
reviewed
Dec 14, 2018
| }, | ||
| "patches": { | ||
| "drupal/core": { | ||
| "Clear Twig caches on deploys": "https://www.drupal.org/files/issues/2752961-130.patch" |
There was a problem hiding this comment.
This is still required for Drupal 8.5.x I think.
|
Closing in favor of #3289, which is based on this branch with just one change to make tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports bugfixes and other features related to code updates and deploys from BLT 9.2 to BLT 9.x in preparation for an upcoming 9.1.9 release of BLT. This release will allow for leveraging the fixes in 9.2.x without requiring an update of Drupal core to 8.6.0.