Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3366: Exclude ACSF files from code sniffing. #3419

Merged
merged 2 commits into from
Mar 6, 2019

Conversation

danepowell
Copy link
Contributor

Fixes #3366

Changes proposed:

Steps to replicate the issue:

  1. Create a new BLT project.
  2. Initialize ACSF (blt acsf:init)
  3. Try to commit the result. Note the error in PHPCS is invoked inconsistently between blt validate and git pre-commit hooks #3366.
  4. Run blt validate. Note that it passes okay.

The problem here is both the error in #3 and the fact that there's a discrepancy between #3 and #4.

Steps to verify the solution:

Same steps as above, but verify that there is no error.

@mikemadison13
Copy link
Contributor

@danepowell i think we should roll this back to 9.2.x and 9.x if they are using phpcs 3.x (i think 9.2.x is?)

@danepowell
Copy link
Contributor Author

Definitely, I'll backport after/if we approve this.

@danepowell danepowell merged commit 611a755 into acquia:10.0.x Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants