Skip drupal:update if Drupal is not installed #3831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3277
Changes proposed
This change checks to see if a site can bootstrap via
Inspector::isDrupalInstalled
before invoking thedrupal:update
command. If the site cannot bootstrap, it logs a warning but continues to attempt database updates on other multisites.Steps to replicate the issue
The steps originally outlined in #3277 suffice but locally you can replicate this by:
blt auda
Previous (bad) behavior, before applying PR
The previous behavior would cause the
blt auda
command to fail on a.com. This actually has potentially negative consequences like leaving b.com or any number of other multisites in a wonky state during AC deployments.Expected behavior, after applying PR and re-running test steps
The
blt auda
command logs a warning, skips running database updates on a.com and proceeds to b.com.