Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4164: Changing twig and yaml linting namespace #4165

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Issue #4164: Changing twig and yaml linting namespace #4165

merged 3 commits into from
Jun 9, 2020

Conversation

ba66e77
Copy link
Contributor

@ba66e77 ba66e77 commented Jun 8, 2020

... references from tests: to validate: namespace.

Fixes #4164

Changes proposed

(What are you proposing we change? How does this impact end users? Are manual or automatic updates required?)

  • Change the namespace used for twig and yaml linting from tests: to validate:. The commands themselves appear to already have been moved and only their invocation in a couple places and documentation still needs to change.

  • Found essentially the same thing with the git commit invocation of tests:composer:validate, which should be validate:composer.

Steps to replicate the issue

  1. With BLT 12.0.0, make some changes, add them to git, and run git commit -m "Whatever."
  2. Observe error message as below.

Previous (bad) behavior, before applying PR

Running git commit without --no-verify on the 12.0.0 release of BLT results in an error saying

[CompletionWrapper] There are no commands defined in the "tests:twig:lint" namespace.

Expected behavior, after applying PR and re-running test steps

No error message displayed

@danepowell
Copy link
Contributor

Thanks, that makes sense!

@danepowell danepowell merged commit 37f9849 into acquia:12.x Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No commands defined in tests:twig:lint namespace error when running git commit
2 participants