Merge pull request #8 from gabesullice/allow-assert-expressions

Exclude the Security.BadFunctions.Asserts sniff.
acquia · Feb 4, 2020 · 89a0747 · 89a0747
2 parents 1c5ba0c + 9612acc
commit 89a0747
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/Standards/AcquiaDrupalStrict/ruleset.xml b/src/Standards/AcquiaDrupalStrict/ruleset.xml
@@ -33,7 +33,10 @@
   <rule ref="DrupalPractice"/>
 
   <!-- PHPCS_SecurityAudit sniffs -->
-  <rule ref="Security.Drupal8"/>
+  <rule ref="Security.Drupal8">
+    <!-- Security.BadFunctions.Asserts forces assertions to use string expressions. String expressions have been deprecated since PHP 7.2.0 -->
+    <exclude name="Security.BadFunctions.Asserts"/>
+  </rule>
 
   <!-- Acquia PHP sniffs -->
   <rule ref="AcquiaPHP"/>

diff --git a/src/Standards/AcquiaDrupalTransitional/ruleset.xml b/src/Standards/AcquiaDrupalTransitional/ruleset.xml
@@ -33,7 +33,10 @@
   <rule ref="DrupalPractice.Commenting.ExpectedException"/>
 
   <!-- PHPCS_SecurityAudit sniffs -->
-  <rule ref="Security.Drupal8"/>
+  <rule ref="Security.Drupal8">
+    <!-- Security.BadFunctions.Asserts forces assertions to use string expressions. String expressions have been deprecated since PHP 7.2.0 -->
+    <exclude name="Security.BadFunctions.Asserts"/>
+  </rule>
 
   <!-- Acquia PHP sniffs -->
   <rule ref="AcquiaPHP"/>