Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCH-6061: Fix deprecations for symfony 3.4. #148

Merged
merged 8 commits into from
Jun 3, 2022
Merged

LCH-6061: Fix deprecations for symfony 3.4. #148

merged 8 commits into from
Jun 3, 2022

Conversation

amangrover90
Copy link
Contributor

No description provided.

saxumVermes
saxumVermes requested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@saxumVermes saxumVermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here as well, we can revise the dispatch() arguments. From Symfony 5 ordering changes, better get ahead of that deprecation.

@saxumVermes
Copy link
Contributor

Also all the symfony 3.4 from composer.json needs to be removed.

@amangrover90
Copy link
Contributor Author

Yeah I missed that, was gonna do it after lunch.

narendradesai
narendradesai approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@narendradesai narendradesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

saxumVermes
saxumVermes approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@saxumVermes saxumVermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's roll it!

@saxumVermes saxumVermes merged commit 0a97044 into 2.x Jun 3, 2022
@saxumVermes saxumVermes deleted the LCH-6061 branch June 3, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saxumVermes saxumVermes saxumVermes approved these changes

@narendradesai narendradesai narendradesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amangrover90 @saxumVermes @narendradesai