LCH-6272: Remove type hint, allow integer values for scroll. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narendradesai
approved these changes
Dec 13, 2022
amangrover90
added a commit
that referenced
this pull request
Jan 10, 2023
* LCH-6272: Remove type hint, allow integer values for scroll. (#156) * LCH-6253: Fix php-stan issues in content-hub-php (#157) * LCH-6238: Enable PHP8 job. * LCH-6238: Update phpunit version. * LCH-6238: Add directory at the end to generate deprecation message. * LCH-6238: Stop phpunit tests on failure. * LCH-6238: Adding phpstan. * LCH-6238: Adding level 1 php stan. * LCH-6253: Adding phpstan config file. * LCH-6253: Scanning directories. * LCH-6253: Autoload directories. * LCH-6253: Autoload directories. * LCH-6253: Autoload directories. * LCH-6253: Autoload directories. * LCH-6253: Ignoring class not found erros. * LCH-6253: Fixing phpstan errors. * LCH-6253: Ignore phpstan errors. * LCH-6253: Adding excludepaths. * LCH-6253: Updating the return type hint and fixing guzzle version less than 7.5. * LCH-6253: Use <8.0 as the pinned upper version. Co-authored-by: Amandeep Singh <arshgrover32@gmail.com> Co-authored-by: Peter Pajor <peter.pajor@acquia.com> * LCH-6300: Use composition instead of inheritance. * LCH-6300: Provide return types. * LCH-6300: Update neon config. * LCH-6300: Move implementation into common trait, use composition for logging client. * LCH-6300: Disable coverage report. * LCH-6300: Reenable coverage report. * LCH-6300: Setting a minimum version for coveralls. Co-authored-by: Narendra Shenvi Desai <shenvidesainarendra@gmail.com> Co-authored-by: Amandeep Singh <arshgrover32@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.