Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCH 6790 3.4.x : Port maintenance mode changes #188

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

kirtigarg2584
Copy link

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

Copy link
Contributor

@narendradesai narendradesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test coverage. Looks fine

@narendradesai narendradesai merged commit 6ac3d7b into 3.4.x Dec 4, 2023
6 checks passed
@narendradesai narendradesai deleted the LCH-6790-3.4.x branch December 4, 2023 12:57
/**
* Returned when the service is intentionally configured to be in maintenance.
*/
public const SERVICE_UNDER_MAINTENANCE = 503;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the wrong maintenance code @narendradesai @kirtigarg2584

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is supposed to be 5031

@saxumVermes
Copy link
Contributor

This PR needs to be reopened @kirtigarg2584

@narendradesai
Copy link
Contributor

@saxumVermes @kirtigarg2584 Created PR to update maintenance mode code: #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants