Issue #2831550 by phenaproxima: Lightning Core Entity Load creating i…

…nfinite loop on Taxonomy

.travis.yml

@@ -95,8 +95,5 @@ script:
   - composer validate --no-check-all --ansi
   - behat --strict --stop-on-failure
 
-after_script:
-  - cat ../../../tmp/selenium.log
-
 matrix:
   fast_finish: true

modules/lightning_features/lightning_core/lightning_core.module

@@ -69,14 +69,29 @@ function lightning_core_modules_installed(array $modules) {
 /**
  * Implements hook_entity_load().
  */
-function lightning_core_entity_load(array $entities, $entity_type_id) {
+function lightning_core_entity_load(array $entities) {
+  // Maintain a list of entity UUIDs whose aliases we've already looked up.
+  // We only want to look up a particular entity's alias once per request in
+  // order to prevent infinite loops (see issue #2831550).
+  static $looked_up = [];
+
   /** @var \Drupal\Core\Path\AliasStorageInterface $alias_storage */
   $alias_storage = \Drupal::service('path.alias_storage');
 
   foreach ($entities as $entity) {
+    $uuid = $entity->uuid();
+
     // If the entity has an empty path field, try to set its value. Amazingly,
     // Path does not do this on its freaking own.
-    if ($entity instanceof FieldableEntityInterface && $entity->hasField('path') && $entity->path instanceof PathFieldItemList && $entity->path->isEmpty()) {
+    if (
+      empty($looked_up[$uuid]) &&
+      $entity instanceof FieldableEntityInterface &&
+      $entity->hasField('path') &&
+      $entity->path instanceof PathFieldItemList &&
+      $entity->path->isEmpty()
+    ) {
+      $looked_up[$uuid] = TRUE;
+
       $alias = $alias_storage->load([
         'source' => '/' . $entity->toUrl()->getInternalPath(),
       ]);