Conversation
…ich disables Metatag's normalizers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited that we might get this in soon. We need PRs against BLT, DF, and Lightning Project that add
- The required additional installer paths
- The asset packagist repository
- Additional installer types
And those PRs need to be merged before we can merge this. Is there anything else that a scaffold project needs to change?
"drupal/simple_oauth": "^2.0@RC" | ||
"drupal/simple_oauth": "^2.0@RC", | ||
"oomphinc/composer-installers-extender": "^1.1", | ||
"drupal/dropzonejs": "^1.0@alpha", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project is alpha stability which means we must pin to a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should get rid of the superfluous @ stability tags too. If we're going to assume the scaffold project has the proper installer paths, we can assume it has stability set to dev too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if we could require a minimum global version of composer (1.5.0) here (like you can for php). But I don't think there is a way to do that. If you require composer/composer it just puts it in vendor and provides a bin.
This is a one-two punch of win that addresses https://www.drupal.org/node/2672038 and https://www.drupal.org/node/2870739 simultaneously.
It takes advantage of the improvements in Composer 1.5 to bring in the Dropzone JavaScript library, and the DropzoneJS Drupal module, to provide a bulk upload form in Lightning. This is the reference implementation of my preferred standard way to import JavaScript libraries into Lightning -- via Asset Packagist.