Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Support bulk upload of media assets #425

Merged
merged 8 commits into from Aug 14, 2017
Merged

Support bulk upload of media assets #425

merged 8 commits into from Aug 14, 2017

Conversation

phenaproxima
Copy link
Collaborator

This is a one-two punch of win that addresses https://www.drupal.org/node/2672038 and https://www.drupal.org/node/2870739 simultaneously.

It takes advantage of the improvements in Composer 1.5 to bring in the Dropzone JavaScript library, and the DropzoneJS Drupal module, to provide a bulk upload form in Lightning. This is the reference implementation of my preferred standard way to import JavaScript libraries into Lightning -- via Asset Packagist.

Copy link
Contributor

@balsama balsama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited that we might get this in soon. We need PRs against BLT, DF, and Lightning Project that add

  • The required additional installer paths
  • The asset packagist repository
  • Additional installer types

And those PRs need to be merged before we can merge this. Is there anything else that a scaffold project needs to change?

"drupal/simple_oauth": "^2.0@RC"
"drupal/simple_oauth": "^2.0@RC",
"oomphinc/composer-installers-extender": "^1.1",
"drupal/dropzonejs": "^1.0@alpha",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project is alpha stability which means we must pin to a release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get rid of the superfluous @ stability tags too. If we're going to assume the scaffold project has the proper installer paths, we can assume it has stability set to dev too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could require a minimum global version of composer (1.5.0) here (like you can for php). But I don't think there is a way to do that. If you require composer/composer it just puts it in vendor and provides a bin.

@balsama balsama changed the base branch from 8.x-2.x to bulk-upload August 14, 2017 13:28
@balsama balsama merged commit 4b564eb into acquia:bulk-upload Aug 14, 2017
@phenaproxima phenaproxima deleted the bulk-upload branch August 14, 2017 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants