Replacing selenium with phantomjs.

[grasmash]

No description provided.

[grasmash]

This test failure appears to be unrelated. Is the media feature broken upstream?

[phenaproxima]

Judging by Travis' output, it looks like there might be a syntax error in composer.json?

[grasmash]

@phenaproxima There was, yes. It's been fixed. There is now a failing media test in this build: https://travis-ci.org/acquia/lightning/builds/100441364

[phenaproxima]

That is one hell of a weird error; as far as I can tell, the x-factor appears to be the introduction of PhantomJS. Maybe PhantomJS is not compatible with the tests, or with our JS? (We are using a few relatively new techniques, like ES6 Promises -- although we have a polyfill for that.)

[grasmash]

Yeah, it's totally possible that PhantomJS doesn't play well with that. My main goal in this PR is to reduce the noise in the logs created by Selenium. A secondary goal is to make testing faster by making it headless.

[balsama]

I think we had a few things going on here. Foremost, the media_library.feature was failing periodically (~20%). When we introduced phantom, it was failing ~80% of the time. Introducing a pause before trying to click on the media WYSIWYG button fixed this so I think we were runninginto an issue where CKEditor wasn't fully loaded some of the time (more often with phantom because it's faster(?)).

Once I introduced that 1-second delay, everything passed locally 100% of the time using both selenium or phantomjs. But Travis was failing with a new error on the media_library.feature:

And I execute the "media_library" command in CKEditor "edit-body-0-value" # LightningSubContext::iExecuteTheCommandInCkeditor()
      {"errorMessage":"'undefined' is not a function (evaluating 'this.onTabActivate.bind(this)')","request":{"headers":{"Accept":"application/json;charset=UTF-8","Content-Length":"99","Content-Type":"application/json;charset=UTF-8","Host":"localhost:4444"},"httpVersion":"1.1","method":"POST","post":"{\"script\":\"return CKEDITOR.instances['edit-body-0-value'].execCommand('media_library');\",\"args\":[]}","url":"/execute","urlParsed":{"anchor":"","query":"","file":"execute","directory":"/","path":"/execute","relative":"/execute","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/execute","queryKey":{},"chunks":["execute"]},"urlOriginal":"/session/50d1c440-b4ab-11e5-afcd-4d40947bd52d/execute"}} (WebDriver\Exception\UnknownError)

I swapped selenium back in and travis is happy.

I'm happy to switch to phantomjs still (agree the cleaner logs are nice) but I'm not sure what's causing the above error. So, for now, we;re back to selenium.

[grasmash]

We're looking at including Lightning in all of our project by default, but we need resolve the issue with media_library that you encountered, since we use PhantomJS in PS.

[balsama]

Great. We can re-prioritize this. It was a dead end for me if I remember correctly - couldn't find any clues as to why it was failing on travis specifically. Maybe some fresh eyes will help. I or @phenaproxima will take another look before the end of the week. Thanks.

[grasmash]

It looks like this is due to PhantomJS not having the prototype.bind() function that CKEditor relies on. This has been solved with non-PHP implementation of PhantomJS, gotta look into a solution for us.

See:

• 0.8.2 breaks my tests running in the PhantomJS webpack-contrib/style-loader#31
• TypeError: 'undefined' is not a function (evaluating 'shortcutMethod.bind(null, addMethods)') stampit-org/stampit#175

Possible solution:
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_objects/Function/bind#Polyfill