Merge pull request #55 from jamesiarmes/doctor-exit

Ensure that doctor exits non-zero if any checks fail.

lib/moonshot/cli.rb

@@ -139,7 +139,8 @@ def delete
 
     desc :doctor, 'Run configuration checks against current environment.'
     def doctor
-      controller.doctor
+      success = controller.doctor
+      raise Thor::Error, 'One or more checks failed.' unless success
     end
   end
 end

lib/moonshot/controller.rb

@@ -66,11 +66,15 @@ def delete
 
     def doctor
       # @todo use #run_hook when Stack becomes an InfrastructureProvider
-      stack.doctor_hook
-      run_hook(:build, :doctor)
-      run_hook(:repo, :doctor)
-      run_hook(:deploy, :doctor)
-      run_plugins(:doctor)
+      success = true
+      success &&= stack.doctor_hook
+      success &&= run_hook(:build, :doctor)
+      success &&= run_hook(:repo, :doctor)
+      success &&= run_hook(:deploy, :doctor)
+      results = run_plugins(:doctor)
+
+      success = false if results.value?(false)
+      success
     end
 
     def stack
@@ -125,9 +129,13 @@ def run_hook(type, name, *args)
     end
 
     def run_plugins(type)
+      results = {}
       @config.plugins.each do |plugin|
-        plugin.send(type, resources) if plugin.respond_to?(type)
+        next unless plugin.respond_to?(type)
+        results[plugin] = plugin.send(type, resources)
       end
+
+      results
     end
 
     def get_mechanism(type)

lib/moonshot/doctor_helper.rb

@@ -15,20 +15,25 @@ def doctor_hook
     private
 
     def run_all_checks
+      success = true
       puts
       puts self.class.name.split('::').last
       private_methods.each do |meth|
         begin
           send(meth) if meth =~ /^doctor_check_/
         rescue DoctorCritical
           # Stop running checks in this Mechanism.
+          success = false
           break
         rescue => e
+          success = false
           print '  ✗ '.red
           puts "Exception while running check: #{e.class}: #{e.message.lines.first}"
           break
         end
       end
+
+      success
     end
 
     def success(str)