Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yarn.lock #50

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Remove yarn.lock #50

merged 1 commit into from
Jul 6, 2022

Conversation

lauriii
Copy link
Contributor

@lauriii lauriii commented Jul 6, 2022

Even if we use yarn internally, from the basic starter users perspective there's no reason to require using yarn. We can remove yarn.lock from the basic starter and the lock file will be created when the project is created from the starter kit.

@lauriii lauriii requested a review from harumijang July 6, 2022 13:54
@lauriii
Copy link
Contributor Author

lauriii commented Jul 6, 2022

Steps for testing this:

  • Ensure yarn is installed on your environment
  • Run npx create-next-app -e https://github.com/acquia/next-acms/tree/remove-yarn-lock/starters/basic-starter and confirm that yarn is used for installing and yarn.lock exists after the command has run
  • Run npx create-next-app -e https://github.com/acquia/next-acms/tree/remove-yarn-lock/starters/basic-starter --use-npm and ensure npm is used for installing and package-lock.json exists but yarn.lock doesn't exist

Copy link
Contributor

@harumijang harumijang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, works as expected

@lauriii lauriii merged commit 5e7f9e3 into main Jul 6, 2022
@lauriii lauriii deleted the remove-yarn-lock branch July 6, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants