Skip to content
This repository has been archived by the owner on Nov 16, 2018. It is now read-only.

Fetch embedded resources #29

Merged
merged 4 commits into from
Aug 8, 2016
Merged

Fetch embedded resources #29

merged 4 commits into from
Aug 8, 2016

Conversation

mattgrill
Copy link

Fetch embedded resources from a JSON document returned from Drupal. This should address some of the requests in #22

Fetch embedded resources from a JSON document returned from Drupal.
@mattgrill mattgrill added this to the 0.7.0 milestone Aug 3, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d44fdd2 on fetch-embedded into 1e4721f on 0.7.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e071b56 on fetch-embedded into 1e4721f on 0.7.0.

});
});

links = Array.from(new Set(links));
Copy link

@infiniteluke infiniteluke Aug 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment about not wanting to fetch the same resource multiple times hence the use of Set could help future contributors. Also a note about Promise.all needing an array. ??

@infiniteluke
Copy link

This is awesome! 🎉

@mattgrill
Copy link
Author

@infiniteluke 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5032fa5 on fetch-embedded into 1e4721f on 0.7.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 81822e2 on fetch-embedded into 1e4721f on 0.7.0.

@prestonso
Copy link
Contributor

LGTM :shipit:

@prestonso prestonso merged commit e50b02e into 0.7.0 Aug 8, 2016
@prestonso prestonso deleted the fetch-embedded branch August 8, 2016 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants