Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build failures on macOS #170

Merged
merged 12 commits into from
Feb 21, 2024
Merged

Fix build failures on macOS #170

merged 12 commits into from
Feb 21, 2024

Conversation

aliddell
Copy link
Member

@aliddell aliddell commented Feb 21, 2024 •
edited

  • Pin cc dependency to 1.0.83 (possible issue).
  • Remove erroneously specified target triple in build script.
  • Consolidate build jobs between target platforms.

@aliddell aliddell marked this pull request as ready for review February 21, 2024 21:18
@aliddell aliddell requested a review from nclack February 21, 2024 21:19
nclack
nclack approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aliddell aliddell merged commit df846c7 into acquire-project:main Feb 21, 2024
32 checks passed
@aliddell aliddell deleted the test-build-macos branch February 21, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nclack nclack nclack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aliddell @nclack