Merge pull request #12 from emiro85/master

Fix ReferenceError if symfile is not included in form
acrisci · Sep 1, 2017 · ae2345f · ae2345f
2 parents 616a282 + 0b15a35
commit ae2345f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/app.coffee b/src/app.coffee
@@ -241,7 +241,7 @@ run = ->
   breakpad.get '/symfiles/:id', (req, res, next) ->
     Symfile.findById(req.params.id).then (symfile) ->
       if not symfile?
-        resturn res.send 404, 'Symfile not found'
+        return res.send 404, 'Symfile not found'
 
       if 'raw' of req.query
         res.set 'content-type', 'text/plain'
@@ -314,7 +314,7 @@ run = ->
 
   breakpad.use(busboy())
   breakpad.post '/symfiles', (req, res, next) ->
-    Symfile.createFromRequest req, (err, symfile) ->
+    Symfile.createFromRequest req, res, (err, symfile) ->
       return next(err) if err?
       symfileJson = symfile.toJSON()
       delete symfileJson.contents

diff --git a/src/model/symfile.coffee b/src/model/symfile.coffee
@@ -49,7 +49,7 @@ Symfile.saveToDisk = (symfile) ->
     filePath = path.join(symfileDir, symbol_name)
     fs.writeFile(filePath, symfile.contents)
 
-Symfile.createFromRequest = (req, callback) ->
+Symfile.createFromRequest = (req, res, callback) ->
   props = {}
   streamOps = []
 
@@ -67,7 +67,7 @@ Symfile.createFromRequest = (req, callback) ->
 
   req.busboy.on 'finish', ->
     Promise.all(streamOps).then ->
-      if not 'symfile' of props
+      if not props.hasOwnProperty('symfile')
         res.status 400
         throw new Error 'Form must include a "symfile" field'