Add down-to command, update dev dependencies #4
Conversation
| @@ -29,15 +33,19 @@ Please specify DATABASE_URL to run this CLi. Try the following: | |||
|
|
|||
| const db = new Kysely({ | |||
| dialect: new PostgresDialect({ | |||
| connectionString: DATABASE_URL, | |||
| pool: new Pool({ | |||
There was a problem hiding this comment.
the newer version of the pg dialect uses a pool instance to specify the connection string
|
|
||
| if (name === 'NO_MIGRATIONS') { | ||
| console.log(`Migrating all the way down`) | ||
| results = await migrator.migrateTo(NO_MIGRATIONS) |
There was a problem hiding this comment.
the NO_MIGRATIONS constant value is not a string, so it has to be imported directly from kysely.
There was a problem hiding this comment.
hm, just realized kysely is a dev dep, maybe we should just copy the NO_MIGRATIONS const value to this file and so it can remain as such:
const NO_MIGRATIONS: NoMigrations = freeze({ __noMigrations__: true })There was a problem hiding this comment.
Users will install kysely on their own, so I think the current code is okay
There was a problem hiding this comment.
I'm not 100% sure what NO_MIGRATIONS does, even though reading the doc 😄
However, it is officially supported by Kysely so I'll make this as is.
| @@ -1,7 +1,7 @@ | |||
| import fs from 'fs' | |||
|
|
|||
| import { program } from 'commander' | |||
| import { Kysely, MigrationResultSet, Migrator } from 'kysely' | |||
| import {Kysely, MigrationResultSet, Migrator, NO_MIGRATIONS} from 'kysely' | |||
There was a problem hiding this comment.
might want to do import type to prevent non-types from being imported such as NO_MIGRATIONS (see note below)
| @@ -29,15 +33,19 @@ Please specify DATABASE_URL to run this CLi. Try the following: | |||
|
|
|||
| const db = new Kysely({ | |||
| dialect: new PostgresDialect({ | |||
| connectionString: DATABASE_URL, | |||
| pool: new Pool({ | |||
|
|
||
| if (name === 'NO_MIGRATIONS') { | ||
| console.log(`Migrating all the way down`) | ||
| results = await migrator.migrateTo(NO_MIGRATIONS) |
There was a problem hiding this comment.
Users will install kysely on their own, so I think the current code is okay
|
|
||
| if (name === 'NO_MIGRATIONS') { | ||
| console.log(`Migrating all the way down`) | ||
| results = await migrator.migrateTo(NO_MIGRATIONS) |
There was a problem hiding this comment.
I'm not 100% sure what NO_MIGRATIONS does, even though reading the doc 😄
However, it is officially supported by Kysely so I'll make this as is.
src/run.ts
Outdated
| .argument('<migration-name>') | ||
| .description('Migrates down to the specified migration name. Specify "NO_MIGRATIONS" to migrate all the way down.') | ||
| .action(async (name) => { | ||
| let results |
There was a problem hiding this comment.
Please type the variable
| let results | |
| let results: MigrationResultSet |
|
Also I should state what |
|
@theogravity Thanks! |
|
Released on v0.2.0 |
This adds a
down-tocommand, which callsmigrator.migrateTo()to migrate down to a specified migration name (or no migrations entirely).Also updated the dev deps to the latest
kysleyand typescript version and fixed related TS issues.