Make month event min height customizable and fix for custom events #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acro5piano
requested changes
Nov 2, 2021
There was a problem hiding this comment.
Thank you for your pull request!
Can you add a bit explanation for this new prop? It must be helpful for new one trying this lib.
https://github.com/acro5piano/react-native-big-calendar#api-documentation
src/components/CalendarContainer.tsx
Outdated
| @@ -73,6 +73,7 @@ export interface CalendarContainerProps<T> { | |||
| onPressEvent?: (event: ICalendarEvent<T>) => void | |||
| weekEndsOn?: WeekNum | |||
| maxVisibleEventCount?: number | |||
| eventMinHeight?: number | |||
There was a problem hiding this comment.
Can you rename it to eventMinHeightForMonthView as it affects only for the month view?
acro5piano
approved these changes
Nov 4, 2021
|
Thanks for your contribution! Released on https://github.com/acro5piano/react-native-big-calendar/releases/tag/v2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized my code for spanning events in month mode wasn't working with custom event render so I fixed that and also made the min height for the event customizable for more flexibility.