add active date props to header #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acro5piano
requested changes
Nov 6, 2021
There was a problem hiding this comment.
@kbwo Thank you for your pull request!
- Can you add this property to the api documentation ?
isActiveDayandactiveDateis confusing. Do you mean highlighting a specific date (Date) or a specific day (0..6) ?
|
|
@acro5piano |
acro5piano
requested changes
Nov 8, 2021
src/components/CalendarHeader.tsx
Outdated
| @@ -46,6 +48,7 @@ function _CalendarHeader<T>({ | |||
| <View style={[u['z-10'], u['w-50'], borderColor]} /> | |||
| {dateRange.map((date) => { | |||
| const _isToday = isToday(date) | |||
| const _isActiveDate = activeDate ? isActiveDate(date, activeDate) : _isToday | |||
There was a problem hiding this comment.
There should be performance improvement: if activeDate is passed, _isToday will be calculated but not used.
So, the logic should be like this:
const shouldHighlight = activeDate ? date.isSame(activeDate, 'date') : isToday(date)
return (Also, please note that
- The var name
shouldHighlightis more clear - I think the function
isActiveDateis a bit redundant, writing it inline must be simpler isSame(.., 'date')is more clear thanisSame(.., 'day')in this case
Sorry that I couldn't find it at the first time ;)
There was a problem hiding this comment.
Thank you for your review. I'll fix it!
|
@acro5piano fixed according to your review! |
kbwo
force-pushed
the
feature/add-active-date-props
branch
from
800cd46
to
301f97b
Compare
acro5piano
requested changes
Nov 8, 2021
src/components/CalendarHeader.tsx
Outdated
Comment on lines
49
to
52
| {dateRange.map((date) => { | ||
| const _isToday = isToday(date) | ||
| const shouldHighlight = activeDate ? date.isSame(activeDate, 'date') : _isToday | ||
| return ( |
There was a problem hiding this comment.
To reduce unnecessary function call, please do
Suggested change
| {dateRange.map((date) => { | |
| const _isToday = isToday(date) | |
| const shouldHighlight = activeDate ? date.isSame(activeDate, 'date') : _isToday | |
| return ( | |
| {dateRange.map((date) => { | |
| const shouldHighlight = activeDate ? date.isSame(activeDate, 'date') : isToday(date) | |
| return ( |
|
Thank you for your contribution! |
|
Released on v2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first, thank you for great library.
I want new feature to display date of blue style except today, so I added active date props to header on this PR.