New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chrismaree/mainnet deployment #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! everything looks good, no issues
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@across-protocol/contracts-v2", | |||
"version": "0.0.44", | |||
"version": "0.0.47", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 this matches the version I just pushed
@@ -0,0 +1,41 @@ | |||
# Across Mainnet Deployment Addresses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewers! see this file
@@ -0,0 +1,73 @@ | |||
// import { getDeployedAddress } from "../src/DeploymentUtils"; | |||
|
|||
import { task, types } from "hardhat/config"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewers! see this file
|
||
console.log("\n7. Adding calldata to set the pool rebalance route for the respective destination tokens:"); | ||
i = 0; // reset counter for logging. | ||
enabledChainIds.forEach((toId, toIndex) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nit: why not just use toIndex
instead of i
in {++i}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point
tsconfig.json
Outdated
"module": "commonjs", | ||
"strict": true, | ||
"strict": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we don't commit this change to strict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. will fix with more strict typing and revert this change.
No description provided.