Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slim): fix docker tag for slim image #83

Merged
merged 3 commits into from
Mar 23, 2023
Merged

fix(slim): fix docker tag for slim image #83

merged 3 commits into from
Mar 23, 2023

Conversation

david-leifker
Copy link
Contributor

@david-leifker david-leifker commented Mar 23, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Mar 23, 2023 •
edited

Unit Test Results (build & test)

63 tests  +63   63 ✔️ +63   3s ⏱️ +3s
  1 suites +  1     0 💤 ±  0 
  1 files   +  1     0 ❌ ±  0 

Results for commit 21d4883. ± Comparison against base commit 91590e3.

♻️ This comment has been updated with latest results.

@david-leifker david-leifker force-pushed the fix_slim_base_image branch 2 times, most recently from 47397e2 to ed2476b Compare March 23, 2023 19:14
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/datahub-actions-docker.yml:image_scan_slim. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

@david-leifker david-leifker enabled auto-merge (squash) March 23, 2023 20:08
shirshanka
shirshanka approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-leifker david-leifker merged commit 6889802 into main Mar 23, 2023
@david-leifker david-leifker deleted the fix_slim_base_image branch March 23, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@anshbansal anshbansal Awaiting requested review from anshbansal

@RyanHolstien RyanHolstien Awaiting requested review from RyanHolstien

@pedro93 pedro93 Awaiting requested review from pedro93

@hsheth2 hsheth2 Awaiting requested review from hsheth2

@meyerkev meyerkev Awaiting requested review from meyerkev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david-leifker @shirshanka