Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP][workflow_task] Remove the technical field ref_object from the a… #122

Merged

Conversation

lmignon
Copy link
Member

@lmignon lmignon commented Jul 25, 2016

…dvanced search

ping @sbidoul @adrienpeiffer

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage increased (+0.9%) to 36.467% when pulling 04f8553 on 9.0-workflow-taks-filter-search-field-lmi into 2929f3a on 9.0-workflow-task-sbi.

# remove ref_object from searchable field into the advanced search
# since the field to use is ref_object_name
if 'ref_object' in res:
res['ref_object']['searchable'] = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not define searchable=False directly on the field ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrienpeiffer unfortunately no 😭 searchableis defined as a python property on fields.Field https://github.com/odoo/odoo/blob/9.0/openerp/fields.py#L675
You can see at line 125 how odoo compute the list of attributes returned by the function field_get https://github.com/odoo/odoo/blob/9.0/openerp/fields.py#L125
The only solution I've found is override fields_get to change the value returned to the JS by the server

@adrienpeiffer
Copy link
Contributor

Ok 😄 can you check travis build ?

@lmignon lmignon force-pushed the 9.0-workflow-taks-filter-search-field-lmi branch 2 times, most recently from 736bc07 to b3084e7 Compare July 28, 2016 11:54
@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Changes Unknown when pulling b3084e7 on 9.0-workflow-taks-filter-search-field-lmi into * on 9.0-workflow-task-sbi*.

@lmignon lmignon force-pushed the 9.0-workflow-taks-filter-search-field-lmi branch from b3084e7 to b8bf03a Compare July 28, 2016 11:58
@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage increased (+0.9%) to 36.467% when pulling b8bf03a on 9.0-workflow-taks-filter-search-field-lmi into f47ee7e on 9.0-workflow-task-sbi.

@lmignon
Copy link
Member Author

lmignon commented Jul 28, 2016

@adrienpeiffer LINT_CHECK fixed, 9.0-workflow-task-sbi rebased on origin/9.0 and 9.0-workflow-taks-filter-search-field-lmi rebased on 9.0-workflow-task-sbi...

@adrienpeiffer
Copy link
Contributor

Thanks @lmignon

@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage increased (+0.9%) to 36.467% when pulling b8bf03a on 9.0-workflow-taks-filter-search-field-lmi into f47ee7e on 9.0-workflow-task-sbi.

@adrienpeiffer adrienpeiffer merged commit fb2093b into 9.0-workflow-task-sbi Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants