Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] click-odoo-update: refactor _get_modules_to_update as a separate method #136

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

StefanRijnhart
Copy link
Contributor

Just a simple refactoring to allow our scripts to check beforehand if anything is going to be updated.

@StefanRijnhart StefanRijnhart changed the title [REF] click-odoo-update: refactor out _get_modules_to_update [REF] click-odoo-update: refactor _get_modules_to_update as a separate method Aug 31, 2023
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Keep in mind there are no tests and no docs for these methods so there is a risk they get refactored away at some point.

@sbidoul sbidoul merged commit 9d293be into acsone:master Sep 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants