Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment GitHub action for OCA #3

Closed
wants to merge 31 commits into from
Closed

Experiment GitHub action for OCA #3

wants to merge 31 commits into from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 24, 2020

Basic principle

  • use a base oca-ci container, dedicated to running oca tests and nothing else, with odoo pre-installed (which we'd build nightly)
  • the rest is explicit in the test steps and would be maintained in oca/oca-addons-repo-template
  • no dependency on MQT seem necessary at this stage

@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #3 (058b78a) into 13.0 (38148d6) will increase coverage by 4.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             13.0       #3      +/-   ##
==========================================
+ Coverage   85.40%   89.61%   +4.21%     
==========================================
  Files          28       51      +23     
  Lines        2185     3196    +1011     
==========================================
+ Hits         1866     2864     +998     
- Misses        319      332      +13     
Impacted Files Coverage Δ
mis_builder/models/mis_report.py 79.64% <100.00%> (+0.10%) ⬆️
mis_builder/models/mis_report_instance.py 84.67% <100.00%> (+0.40%) ⬆️
mis_builder/tests/test_mis_report_instance.py 95.74% <100.00%> (ø)
mis_builder/models/aggregate.py 37.50% <0.00%> (-6.25%) ⬇️
mis_builder/tests/test_kpi_data.py 100.00% <0.00%> (ø)
mis_builder/tests/test_aep.py 100.00% <0.00%> (ø)
mis_builder/tests/test_period_dates.py 100.00% <0.00%> (ø)
mis_builder/tests/test_simple_array.py 100.00% <0.00%> (ø)
mis_builder/__init__.py 100.00% <0.00%> (ø)
mis_builder/tests/test_data_sources.py 100.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231d372...058b78a. Read the comment docs.

@lmignon
Copy link
Member

lmignon commented Oct 26, 2020

Great!!!
2m56 vs 5m48s to install and run the tests!!!!
image

vs

image

@sbidoul sbidoul closed this Aug 13, 2021
@sbidoul sbidoul deleted the github-actions-sbi branch August 13, 2021 13:35
@gaikaz
Copy link

gaikaz commented Aug 13, 2021

@sbidoul
This looked promising. Is it being canceled as no more development to use Github Actions will be done?
I was looking forward to adapt this in our internal use as well, so was watching :)

@sbidoul
Copy link
Member Author

sbidoul commented Aug 13, 2021

@gaikaz this is not abandonned. The action is taking place there and will be rolled out to the 14.0 branches soon-ish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants