Skip to content

Commit

Permalink
[FIX] refs #16739 do not call inverse function on field name for natu…
Browse files Browse the repository at this point in the history
…ral person
  • Loading branch information
Cedric-Pigeon committed Sep 30, 2015
1 parent f549ece commit 26a60f6
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 3 deletions.
11 changes: 11 additions & 0 deletions mozaik_person/res_partner.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,17 @@ def _get_partner_names(self, cr, uid, ids, name, args, context=None):
}
return result

@api.one
def _inverse_name_after_cleaning_whitespace(self):
'''
Name field is readonly on mozaik for a natural person
but due to a dependance on readonly_bypass, the inverse function
in partner_firstname is triggered and can change the expected
result. For example if lastname contains space(s).
'''
if self.is_company:
super(res_partner, self)._inverse_name_after_cleaning_whitespace()

# data model

_display_name_store_trigger = {
Expand Down
18 changes: 15 additions & 3 deletions mozaik_person/tests/test_res_partner.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,8 @@ def test_res_partner_duplicates(self):
# Update nouvelobs_bis => duplicates: 2 detected, 0 allowed
partner_model.write(
cr, uid, [nouvelobs_bis_id], {
'name': 'Nouvel Observateur'}, context=context)
'name': 'Nouvel Observateur', 'is_company': True},
context=context)
flds = ['is_duplicate_detected', 'is_duplicate_allowed']
partner_fields = partner_model.read(
cr, SUPERUSER_ID, [
Expand Down Expand Up @@ -347,7 +348,8 @@ def test_res_partner_duplicates(self):
# Create one more 'nouvelobs' => duplicates: 3 detected, 0 allowed
nouvelobs_ter_id = partner_model.create(
cr, uid, {
'name': 'Nouvel Observateur'}, context=context)
'name': 'Nouvel Observateur', 'is_company': True},
context=context)
partner_fields = partner_model.read(
cr, SUPERUSER_ID, [
nouvelobs_id, nouvelobs_bis_id, nouvelobs_ter_id], flds,
Expand Down Expand Up @@ -404,7 +406,8 @@ def test_res_partner_duplicates(self):
# Update nouvelobs_bis => duplicates: 0 detected, 0 allowed
partner_model.write(
cr, uid, [nouvelobs_id], {
'name': 'Nouvel Observateur (Economat)'}, context=context)
'name': 'Nouvel Observateur (Economat)', 'is_company': True},
context=context)
partner_fields = partner_model.read(
cr, SUPERUSER_ID, [
nouvelobs_id, nouvelobs_bis_id], flds, context=context)
Expand Down Expand Up @@ -746,3 +749,12 @@ def test_age_computation(self):
partner = self.partner_model.browse(
cr, uid, partner_id, context=context)
self.assertEquals(partner.age, age, 'Should be the same age')

def test_lastname_firstname(self):
vals = {
'lastname': 'El Ghabri',
'firstname': 'Mohssin',
'name': 'El Ghabri Mohssin'
}
partner = self.env['res.partner'].create(vals)
self.assertEqual(vals['lastname'], partner.lastname)

0 comments on commit 26a60f6

Please sign in to comment.