[CHG] Make the parser python 3 compatible #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
reviewed
Sep 21, 2018
coda/parser.py
Outdated
| @@ -90,7 +90,7 @@ def parse(self, value): | |||
| """ | |||
| if not self.is_valid_coda(value): | |||
| raise ValueError('The given value is not a valid coda content') | |||
| recordlist = unicode(value, 'windows-1252', 'strict').split('\n') | |||
| recordlist = value.decode('windows-1252', 'strict').split('\n') | |||
There was a problem hiding this comment.
in python2 str is bytes and unicode is unicode
in python 3 str is unicode and bytes is bytes
since we are decoding here, the value param must be bytes (str in python 2), so you need to open the files in 'rb' mode (in tests and in parse_file)
RobinetDenisAcsone
force-pushed
the
python3_compatible_drt
branch
from
335cd06
to
317b051
Compare
|
Looks good. Just add in setup.cfg. @lmignon can you review, merge and release? |
lmignon
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.