-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rules.js depends on example-config.js #27
Comments
|
Yeah, this is confusing. So there are two ways where we could use START and END. Either as variables or as These tokens are replaced in src/lib/AtomicBuilder.js. And it gets from the config as well. But not as a file but the config that is fed to the -- edited: added more comments --- |
Fix Issue #27. Removed hard dependencies of a config or utils.
Adding support for codepen embeds
Adding support for codepen embeds
Updated to work with the latest version of Atomizer (3.0.0-alpha.4)
Updated to work with the latest version of Atomizer (3.0.0-alpha.4)
Right now
rules.js
require()'sexample-config.js
to get the$START
and$END
config values. This seems like something that should be passed in if it needs to be configurable, which means making the export a function rather than an array, I think. Do we still need those values to be configurable, @renatoi and @thierryk?The text was updated successfully, but these errors were encountered: