Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules.js depends on example-config.js #27

Closed
src-code opened this issue Jan 30, 2015 · 2 comments
Closed

rules.js depends on example-config.js #27

src-code opened this issue Jan 30, 2015 · 2 comments
Labels

Comments

@src-code
Copy link
Contributor

Right now rules.js require()'s example-config.js to get the $START and $END config values. This seems like something that should be passed in if it needs to be configurable, which means making the export a function rather than an array, I think. Do we still need those values to be configurable, @renatoi and @thierryk?

@src-code src-code added the bug label Jan 30, 2015
@src-code
Copy link
Contributor Author

$START and $END appear to be string tokens - is that something Absurd uses? There's also a single use of the START and END variables, not sure why the differences.

@renatoi
Copy link
Contributor

renatoi commented Feb 2, 2015

Yeah, this is confusing.

So there are two ways where we could use START and END. Either as variables or as $START and $END tokens. I think we can drop their use as variables and just use them as tokens.

These tokens are replaced in src/lib/AtomicBuilder.js.

And it gets from the config as well. But not as a file but the config that is fed to the AtomicBuilder.

-- edited: added more comments ---

src-code added a commit that referenced this issue Feb 2, 2015
Fix Issue #27. Removed hard dependencies of a config or utils.
@src-code src-code closed this as completed Feb 2, 2015
redonkulus pushed a commit that referenced this issue Jul 14, 2022
Adding support for codepen embeds
redonkulus pushed a commit that referenced this issue Jul 14, 2022
Adding support for codepen embeds
redonkulus pushed a commit that referenced this issue Jul 15, 2022
Updated to work with the latest version of Atomizer (3.0.0-alpha.4)
redonkulus pushed a commit that referenced this issue Jul 15, 2022
Updated to work with the latest version of Atomizer (3.0.0-alpha.4)
redonkulus pushed a commit that referenced this issue Jul 16, 2022
redonkulus pushed a commit that referenced this issue Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants