-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add dark mode document #509
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
</body> | ||
``` | ||
|
||
<p class="noteBox info">By default, without the <code>dark</code> class on the page, the dark mode classes will not be applied (even if the user has the dark mode scheme enabled). You would need to add the <code>dark</code> class to your website to "enable" the dark mode classes. Read the <a href="#enabling-dark-mode">Enabling Dark Mode</a> section for tips on how to add the class to your project.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also add an example that does the var changes in css eg
/* overrides for dark mode */
.dark {
--background-color: #333;
--text-color: #fff;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about that but it's annoying when the override styles have to be duplicated in the style sheet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Add dark mode guide for users.