Rewriting include tag to properly match liquid source #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tags/include.go
Outdated
| } | ||
| } | ||
|
|
||
| return core.Normal |
There was a problem hiding this comment.
@ianmburns Should the return core.Normal be inside the switch statement?
thecitydeployer
approved these changes
Mar 14, 2017
mgolus
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @joshua @mgolus @mattbronkema
When we first wrote the additional code for the 'with' and 'for' modifiers on the include tags, we were a bit off with our mapping. We were treating any maps as the main context instead of the include template name as the context key with the map as the value.
Examples
Context:
{item = {address = {city: Charleston, state: SC}}
item.address.city = "Charleston"
{include 'address.liq' with item.address}
Include Context:
Old:
{city: Charleston, state: SC}
city = "Charleston"
New:
{address = {City: Charleston, State: SC}}
address.city = "Charleston"
See https://github.com/Shopify/liquid/blob/master/lib/liquid/tags/include.rb#L58 for example of implementation. I tried to replicate the fall through of "isarray" by allowing the context to be set even if we did not support the array type.