Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13 {% for … reversed %}, and #14 error message #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #13 {% for … reversed %}, and #14 error message #15

wants to merge 2 commits into from

Conversation

osteele
Copy link

@osteele osteele commented Jun 11, 2017

Tested via new test cases and ./t.

This enables this library to work with some Jekyll templates that they formerly failed on.

Also rename "modifier" -> "attribute", to match the Shopify liquid documentation <https://help.shopify.com/themes/liquid/tags/iteration-tags#for>
This also adds a separate unit test for "{% for … reversed %}". `TestTemplateRender1` also (still) tests for this; the new test makes it easier to see exactly what fails.
@osteele osteele changed the title Fix {% for … reversed %}, and error message Fix #13 {% for … reversed %}, and #14 error message Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant