Skip to content

Commit

Permalink
Fix presentational conflict resolution (#1309)
Browse files Browse the repository at this point in the history
* Use non-none explicit role
* Remove useless explicit role
* Disable fields that need to have role of none
  • Loading branch information
Jym77 committed Jun 12, 2020
1 parent c5e32d4 commit 3d9b996
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion _rules/autocomplete-valid-value-73f2c2.md
Expand Up @@ -148,7 +148,7 @@ The `input` element does not participates in sequential focus navigation, but st
The `input` element does not have a semantic role that is a widget role, but still participates in sequential focus navigation because of the [`tabindex` attribute](https://html.spec.whatwg.org/#the-tabindex-attribute), and has a single autocomplete term.

```html
<input role="none" tabindex="0" autocomplete="username" />
<input role="banner" tabindex="0" autocomplete="username" />
```

### Failed
Expand Down
4 changes: 2 additions & 2 deletions _rules/form-control-non-empty-accessible-name-e086e5.md
Expand Up @@ -208,15 +208,15 @@ Hidden to assistive technologies.
Role has [explicitly](#explicit-role) been set to something that isn't a form field.

```html
<input role="presentation" />
<input role="presentation" disabled />
```

#### Inapplicable Example 4

Option inherits from input, but has a required context role of listbox which inherits from select. We should therefore not consider option as applicable.

```html
<select role="none">
<select role="none" disabled>
<option value="volvo">Volvo</option>
<option value="saab">Saab</option>
<option value="opel">Opel</option>
Expand Down

0 comments on commit 3d9b996

Please sign in to comment.