chore: note that acc name testing is out of scope #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
approved these changes
Jan 15, 2020
maryjom
approved these changes
Jan 15, 2020
carlosapaduarte
approved these changes
Jan 15, 2020
Jym77
requested changes
Jan 16, 2020
There was a problem hiding this comment.
I'm not sure what "correct" means in these contexts. It could means "correct" according to some spec of how accessible names are formed; or "correct" in their meaning with respect of the associated element.
"descriptive" of whatever it is naming?
We have several rules that use "descriptive" for accessible names.
WilcoFiers
force-pushed
the
acc-name-notes
branch
from
53c2738
to
da8f387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was requested by the ACT Task Force. They wanted it to be clearer that accessible names have to be tested separately from testing those the accessible name exists.
Need for Final Call: none