Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding WCAG techniques as accessibility mappings (batch 2) #1119

Merged
merged 7 commits into from Feb 6, 2020

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Jan 22, 2020

Follow-up to #1014, handling some more rules.

Closes issue(s):

Need for Final Call:
This will require a 1 week Final Call (small changes to accessibility mappings).


Pull Request Etiquette

When creating PR:

  • Make sure you requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77
Copy link
Collaborator Author

Jym77 commented Jan 30, 2020

Final Call ends on February 6th.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jan 30, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 6, 2020

Final Call has ended. Merging.

@Jym77 Jym77 merged commit 1ebd002 into develop Feb 6, 2020
@Jym77 Jym77 deleted the map-techniques-to-rules-batch-2 branch February 6, 2020 10:06
@Jym77 Jym77 mentioned this pull request Mar 10, 2020
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General for all rules Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map rules to WCAG techniques
4 participants