Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"aria-* attribute is defined in WAI-ARIA" (5f99a7): put context on failed example 1 #1371

Merged
merged 4 commits into from Jul 17, 2020

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Jul 6, 2020

The lack of context on Failed example 1 caused validators to ignore it and pass it.

Closes issue(s):

Need for Final Call:
This will require a 1 week Final Call (Fixing one example)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Jul 6, 2020
@Jym77 Jym77 self-assigned this Jul 6, 2020
Copy link
Collaborator

@dd8 dd8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - with the ul added the W3 validator now reports

  • Attribute aria-not-checked not allowed on element li at this point.
  • Element li is missing required attribute aria-checked.
  • An element with role=menuitemcheckbox must be contained in, or owned by, an element with role=menubar or role=menu.

@Jym77
Copy link
Collaborator Author

Jym77 commented Jul 10, 2020

Final Call ends on July 17.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jul 10, 2020
@carlosapaduarte carlosapaduarte removed their request for review July 14, 2020 15:41
@WilcoFiers WilcoFiers merged commit ab39132 into develop Jul 17, 2020
@Jym77 Jym77 deleted the aria-attribute-defined-fix-failed-example branch July 17, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aria-* attribute is defined in WAI-ARIA - Failed Example 1
4 participants