Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Image filename is accessible name for image" (9eb3f6): Fix examples #1392

Merged
merged 3 commits into from Aug 3, 2020

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Jul 16, 2020

Fix the examples: add missing leading / and correct media queries.

Closes issue(s):


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Jul 16, 2020
@Jym77 Jym77 self-assigned this Jul 16, 2020
Copy link
Collaborator

@dd8 dd8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good

@Jym77
Copy link
Collaborator Author

Jym77 commented Jul 24, 2020

Final Call ends on July 31st.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jul 24, 2020
@WilcoFiers WilcoFiers merged commit 9f34364 into develop Aug 3, 2020
@Jym77 Jym77 deleted the image-filename-fix-examples branch August 10, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image filename is accessible name for image - problems with examples
6 participants