-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup references #1459
Merged
Merged
Cleanup references #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jym77
added
Rule Update
Use this label for an existing rule that is being updated
reviewers wanted
labels
Sep 23, 2020
Jym77
requested review from
WilcoFiers,
kasperisager,
carlosapaduarte,
ShadowBB,
annethyme,
jeeyyy,
adilsofficial,
ajanec01,
daniel-montalvo and
joao-vicente
September 23, 2020 08:48
kasperisager
approved these changes
Sep 23, 2020
WilcoFiers
previously requested changes
Sep 23, 2020
WilcoFiers
approved these changes
Sep 24, 2020
carlosapaduarte
approved these changes
Sep 24, 2020
Final Call ends on October 1st. |
Jym77
added
Review Call 1 week
Call for review for small changes
and removed
reviewers wanted
labels
Sep 24, 2020
Final Call has ended. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Review Call 1 week
Call for review for small changes
Rule Update
Use this label for an existing rule that is being updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
img
point to existing test assets unless missing asset is needed for the example.http
byhttps
in links in test cases.Closes issue(s):
Need for Final Call:
This will require a 1 week Final Call (editorial changes to many examples).
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve