Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup references #1459

Merged
merged 12 commits into from
Oct 1, 2020
Merged

Cleanup references #1459

merged 12 commits into from
Oct 1, 2020

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Sep 23, 2020

  • Correct some test assets paths.
  • Remove links to Facebook and Twitter. Replaced by links to ACT rules resources.
  • Make all img point to existing test assets unless missing asset is needed for the example.
  • Remove protocol relative URLs. All recent doc I can find consider them as anti-pattern.
  • Replace http by https in links in test cases.
  • Remove Inapplicable examples that fail the SC.

Closes issue(s):

  • N/A

Need for Final Call:
This will require a 1 week Final Call (editorial changes to many examples).


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Sep 23, 2020
@Jym77 Jym77 self-assigned this Sep 23, 2020
_rules/attr-not-duplicated-e6952f.md Outdated Show resolved Hide resolved
_rules/links-identical-name-equivalent-purpose-b20e66.md Outdated Show resolved Hide resolved
@Jym77
Copy link
Collaborator Author

Jym77 commented Sep 24, 2020

Final Call ends on October 1st.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Sep 24, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented Oct 1, 2020

Final Call has ended. Merging.

@Jym77 Jym77 merged commit 8e4baa4 into develop Oct 1, 2020
@Jym77 Jym77 deleted the cleanup-references branch October 1, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants