Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear up link-acc-name examples #1465

Merged
merged 5 commits into from Oct 12, 2020
Merged

Clear up link-acc-name examples #1465

merged 5 commits into from Oct 12, 2020

Conversation

WilcoFiers
Copy link
Member

These changes were requested on yesterday's AGWG call. Here is the survey of it: https://www.w3.org/2002/09/wbs/35422/act-rules-2020-09/results#xq3 (only accessible to AGWG members)

Need for Final Call: 1 week


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

```

#### Failed Example 2

This `a` element with a decorative image has an empty [accessible name][].
This `a` element with an image has an empty [accessible name][]. The image is decorative because it has an empty `alt` [attribute value][].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit uneasy on the formulation "the image is decorative because it has empty alt (or role of none)" as it feels like it reverses the causality: the image is decorative because it brings no information. It has an empty alt because it is decorative (and need to be marked as such to UA/AT).

But this is irrelevant to this PR, so not really a problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about if I used "presentational" instead of "decorative"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan either 🤔

I see "decorative" or "presentational" as almost synonyms. And I understand them as intrinsic property of the image, independantly of the techniques used to expose it or not.
Also, the rule (Applicability and Expectation) does not mention being decorative as relevant to it, so it is a bit weird to see that popping up in the description.
I'm not sure exactly what was the request from the AGWG (no access to the survey), so it's hard to figure out what would make everybody happy…

Maybe,

The image is decorative and is marked as such with an empty alt attribute value.

I guess the problem we want to illustrate here is that it is possible to use a decorative image as content for a link, but in that case, author must provide a name for the link (since it is not provided by content) for AT users.

What about a fully explicit version like

This a element has an empty accessible name. Its content is a decorative image which is correctly marked as such with an empty alt attribute value. However, there is nothing else to give a name to the link resulting in an empty accessible name.

(i.e. the error is not the empty alt but the lack of aria-label or such on the link to compensate for decorative content, so we don't say that image links can't be decorative; but we say that if they are decorative, then AT users need something)

Copy link
Collaborator

@maryjom maryjom Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An idea for the description: "This link has an empty accessible name because the link's image is marked as decorative and link text or an ARIA label was not provided."

Saying generically "ARIA label" to cover both aria-label and aria-labelledby. Would this work?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @Jym77 suggestion for "The image is decorative and is marked as such with an empty alt attribute value."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going with @Jym77 's (shortest) suggestion.

@WilcoFiers WilcoFiers changed the title Clear up link-acc-name examples (AGWG request) Clear up link-acc-name examples Sep 30, 2020
@WilcoFiers WilcoFiers added the AGWG request Accessibility Guidelines Working Group label Sep 30, 2020
@WilcoFiers WilcoFiers added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Oct 5, 2020
@WilcoFiers WilcoFiers merged commit 731f368 into develop Oct 12, 2020
@WilcoFiers WilcoFiers deleted the link-acc-name-examples branch October 12, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AGWG request Accessibility Guidelines Working Group Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants