New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINAL: Glossary generation in rules & reverse linking in algorithms #147
Conversation
@annethyme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, kudos! 👍 for explicitly assigning keys to algorithm definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to use the file name instead of key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the result. Have no clue about code quality though.
Checklist for Pull Request
🚨Please review the guidelines for contributing to this repository.
DRAFT
orFINAL
accordingly. For more details, read Rule Design Guidelines#Reviewing Guidelines
DRAFT
PR's, leave any comments you have and approve if you’ve reviewed the entire pull request.FINAL
PR's, review and approve changes to be merged.How to Review And Approve
Description
Note: The hash (#) symbol in hyperlink url is crucial.
Moved older rules/ drafts to outdated directories - issue Add an "outdated" notice to older pages #112
Gif here:
Screenshots below:
💔Thank you!