Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video audio fix #1662

Closed
wants to merge 11 commits into from
Closed

Video audio fix #1662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6e74948
Merge pull request #1 from act-rules/develop
tbostic32 Aug 11, 2020
88cae51
Added required aria-checked attribute for menuitemradio and menuitemc…
tbostic32 Aug 11, 2020
f6e8dad
Merge branch 'develop' into develop
WilcoFiers Aug 24, 2020
8d02d2f
Merge branch 'act-rules:develop' into develop
tbostic32 Jun 29, 2021
4cb779c
Updated rabbit audio codec to work with chrome and FF.
tbostic32 Jun 29, 2021
986cdc5
update perspective video with correct audio format.
tbostic32 Jun 29, 2021
daad4ee
Removed mp4s and all removed or replaced all references to them.
tbostic32 Jul 14, 2021
63e67db
Fixed some bad reference changes.
tbostic32 Jul 14, 2021
098953c
Merge branch 'act-rules:develop' into develop
tbostic32 Jul 14, 2021
e7039f1
Fixed merge conflict.
tbostic32 Jul 14, 2021
ee80643
Didn't save MR conflict file.
tbostic32 Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions _rules/audio-or-video-avoids-automatically-playing-audio-80f0bf.md
View file
Open in desktop
Expand Up @@ -95,7 +95,6 @@ This `video` element does not play for longer than 3 seconds.

```html
<video autoplay>
<source src="/test-assets/rabbit-video/video.mp4#t=8,10" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm#t=8,10" type="video/webm" />
</video>
```
Expand All @@ -122,7 +121,6 @@ This `video` element autoplays and has an [instrument][] to pause, stop, or turn
<div id="video-container">
<!-- Video -->
<video id="video" autoplay>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
<!-- Video Controls -->
Expand Down Expand Up @@ -151,7 +149,6 @@ This `video` element audio autoplays for longer than 3 seconds, and does not hav

```html
<video autoplay>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
```
Expand All @@ -164,7 +161,6 @@ This `video` element audio autoplays for longer than 3 seconds but is `muted`.

```html
<video autoplay muted>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
```
Expand All @@ -175,7 +171,6 @@ This `video` element has no audio output.

```html
<video autoplay>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
</video>
```
Expand Down
4 changes: 0 additions & 4 deletions _rules/auto-play-audio-does-not-exceed-3-seconds-aaa1bf.md
View file
Open in desktop
Expand Up @@ -69,7 +69,6 @@ This `video` element's audio output does not last longer than 3 seconds.

```html
<video autoplay>
<source src="/test-assets/rabbit-video/video.mp4#t=8,10" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm#t=8,10" type="video/webm" />
</video>
```
Expand All @@ -90,7 +89,6 @@ This `video` element plays some audio automatically for more than 3 seconds.

```html
<video autoplay>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
```
Expand All @@ -103,7 +101,6 @@ This `video` element has audio that autoplays for longer than 3 seconds but is m

```html
<video autoplay muted>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
```
Expand All @@ -114,7 +111,6 @@ This `video` element refers to a source file that has no audio output.

```html
<video autoplay>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
</video>
```
Expand Down
8 changes: 0 additions & 8 deletions _rules/auto-play-audio-has-control-mechanism-4c31df.md
View file
Open in desktop
Expand Up @@ -74,7 +74,6 @@ This `video` element has an [instrument][] to pause, stop, or turn the audio vol

```html
<video autoplay controls>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
```
Expand All @@ -101,7 +100,6 @@ This `video` element has a custom [instrument][] to pause or stop or turn the au
<div id="video-container">
<!-- Video -->
<video id="video" autoplay>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
<!-- Video Controls -->
Expand Down Expand Up @@ -130,7 +128,6 @@ This `video` element autoplays and does not have an [instrument][] to pause, sto

```html
<video autoplay>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
```
Expand Down Expand Up @@ -158,7 +155,6 @@ This `video` element has an [instrument][] to pause, stop, or turn the audio vol
<div id="video-container">
<!-- Video -->
<video id="video" autoplay>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
<!-- Video Controls -->
Expand Down Expand Up @@ -193,7 +189,6 @@ This `video` element has an [instrument][] to pause, stop, or turn the audio vol
<div id="video-container">
<!-- Video -->
<video id="video" autoplay>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
<!-- Video Controls -->
Expand Down Expand Up @@ -228,7 +223,6 @@ This `video` element has an [instrument][] to pause, stop, or turn the audio vol
<div id="video-container">
<!-- Video -->
<video id="video" autoplay>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
<!-- Video Controls -->
Expand All @@ -249,7 +243,6 @@ The audio of this `video` element autoplays for longer than 3 seconds but is `mu

```html
<video autoplay muted>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
```
Expand All @@ -260,7 +253,6 @@ The `src` file of this `video` element has no audio output.

```html
<video autoplay>
<source src="/test-assets/rabbit-video/video-with-incorrect-voiceover.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video-with-incorrect-voiceover.webm" type="video/webm" />
</video>
```
Expand Down
6 changes: 3 additions & 3 deletions _rules/object-has-acessible-name-8fc3b6.md
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@ This `object` element which embeds an audio resource has a non-empty [accessible
This `object` element which embeds a video resource has a non-empty [accessible name][] through its `title` attribute.

```html
<object title="Rabbit animated short" data="/test-assets/rabbit-video/video.mp4"></object>
<object title="Rabbit animated short" data="/test-assets/rabbit-video/video.webm"></object>
```

#### Passed Example 3
Expand Down Expand Up @@ -97,7 +97,7 @@ This `object` element placed off screen, which embeds an audio resource, has a n
This `object` element which embeds a video resource has an empty [accessible name][] because the `title` attribute is empty.

```html
<object title="" data="/test-assets/rabbit-video/video.mp4"></object>
<object title="" data="/test-assets/rabbit-video/video.webm"></object>
```

#### Failed Example 2
Expand Down Expand Up @@ -131,7 +131,7 @@ This `object` element which embeds an audio resource has an empty [accessible na
This `object` element is not [included in the accessibility tree][] due to `display:none`.

```html
<object data="/test-assets/rabbit-video/video.mp4" style="display: none;"></object>
<object data="/test-assets/rabbit-video/video.webm" style="display: none;"></object>
```

#### Inapplicable Example 2
Expand Down
8 changes: 0 additions & 8 deletions _rules/video-alternative-for-visual-c5a4ea.md
View file
Open in desktop
Expand Up @@ -102,7 +102,6 @@ This `video` element has an audio description because it has voiceover that desc
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video-with-voiceover.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video-with-voiceover.webm" type="video/webm" />
</video>
</html>
Expand All @@ -115,7 +114,6 @@ A video element with a link to a text transcript.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
<a href="/test-assets/rabbit-video/transcript.html">Transcript</a>
Expand All @@ -129,7 +127,6 @@ A video element with a track element that contains descriptions.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
<track kind="descriptions" src="/test-assets/rabbit-video/descriptions.vtt" />
</video>
Expand Down Expand Up @@ -160,7 +157,6 @@ This `video` element has an incorrect audio description.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video-with-incorrect-voiceover.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video-with-incorrect-voiceover.webm" type="video/webm" />
</video>
</html>
Expand All @@ -173,7 +169,6 @@ A video element with a link to an incorrect text transcript on a different page.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
<a href="/test-assets/rabbit-video/incorrect-transcript.html">Transcript</a>
Expand All @@ -187,7 +182,6 @@ A video element with a track element that contains incorrect descriptions.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
<track kind="descriptions" src="/test-assets/rabbit-video/incorrect-descriptions.vtt" />
</video>
Expand Down Expand Up @@ -218,7 +212,6 @@ A video element without audio.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
</video>
</html>
Expand All @@ -231,7 +224,6 @@ A video element that is not [visible][].
```html
<html lang="en">
<video controls style="display: none;">
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
</html>
Expand Down
9 changes: 2 additions & 7 deletions _rules/video-audio-description-1ea59c.md
View file
Open in desktop
Expand Up @@ -67,7 +67,6 @@ A video element with a voiceover that describes the visual information.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video-with-voiceover.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video-with-voiceover.webm" type="video/webm" />
</video>
</html>
Expand All @@ -86,7 +85,7 @@ A video element with an audio description.
<figure id="ozplayer-1-container" class="ozplayer-container">
<div data-controls="stack" class="ozplayer" id="ozplayer-1">
<video controls="controls" preload="none">
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
<audio data-default="default" preload="none">
<source src="/test-assets/rabbit-video/audio-description.mp3" type="audio/mp3" />
Expand All @@ -112,7 +111,6 @@ A video element without an audio description.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
</html>
Expand All @@ -125,7 +123,6 @@ A video element with an incorrect audio description.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video-with-incorrect-voiceover.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video-with-incorrect-voiceover.webm" type="video/webm" />
</video>
</html>
Expand All @@ -144,7 +141,7 @@ A video element with an incorrect audio description.
<figure id="ozplayer-1-container" class="ozplayer-container">
<div data-controls="stack" class="ozplayer" id="ozplayer-1">
<video controls="controls" preload="none">
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
<audio data-default="default" preload="none">
<source src="/test-assets/rabbit-video/incorrect-audio-description.mp3" type="audio/mp3" />
Expand All @@ -170,7 +167,6 @@ A video element without audio.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
</video>
</html>
Expand All @@ -183,7 +179,6 @@ A video element that is not [visible][].
```html
<html lang="en">
<video controls style="display: none;">
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
</html>
Expand Down
5 changes: 0 additions & 5 deletions _rules/video-description-track-f196ce.md
View file
Open in desktop
Expand Up @@ -66,7 +66,6 @@ A video element with a track element that contains descriptions.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
<track kind="descriptions" src="/test-assets/rabbit-video/descriptions.vtt" />
</video>
Expand All @@ -82,7 +81,6 @@ A video element with a track element that contains incorrect descriptions.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
<track kind="descriptions" src="/test-assets/rabbit-video/incorrect-descriptions.vtt" />
</video>
Expand All @@ -98,7 +96,6 @@ A video element without a track element.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
</video>
</html>
Expand All @@ -111,7 +108,6 @@ A video element that is not [visible][].
```html
<html lang="en">
<video controls style="display: none;">
<source src="/test-assets/rabbit-video/video.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm" type="video/webm" />
<track kind="descriptions" src="/test-assets/rabbit-video/descriptions.vtt" />
</video>
Expand All @@ -125,7 +121,6 @@ A video element without audio.
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
<track kind="descriptions" src="/test-assets/rabbit-video/descriptions.vtt" />
</video>
Expand Down
7 changes: 0 additions & 7 deletions _rules/video-only-alternative-for-visual-c3232f.md
View file
Open in desktop
Expand Up @@ -82,7 +82,6 @@ This `video` element, which has no audio, has a `track` element with description
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
<track kind="descriptions" src="/test-assets/rabbit-video/descriptions.vtt" />
</video>
Expand All @@ -96,7 +95,6 @@ This `video` element, which has no audio, has a text transcript available on the
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4"></source>
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm"></source>
</video>
<p>The above video shows a giant fat rabbit climbing out of a hole in the ground.
Expand All @@ -112,7 +110,6 @@ This `video` element, which has no audio, has a separate audio track that descri
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
</video>

Expand Down Expand Up @@ -146,7 +143,6 @@ This `video` element, which has no audio, has a `track` element with incorrect d
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
<track kind="descriptions" src="/test-assets/rabbit-video/incorrect-descriptions.vtt" />
</video>
Expand All @@ -160,7 +156,6 @@ This `video` element, which has no audio, has a transcript which does not convey
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4"></source>
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm"></source>
</video>
<a href="/test-assets/rabbit-video/incorrect-transcript.html">Transcript</a>
Expand All @@ -174,7 +169,6 @@ This `video` element, which has no audio, has a separate audio track that incorr
```html
<html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
</video>

Expand Down Expand Up @@ -223,7 +217,6 @@ This `video` element is not [visible][].
```html
<html lang="en">
<video controls style="display: none;">
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4" />
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm" />
<track kind="descriptions" src="/test-assets/rabbit-video/descriptions.vtt" />
</video>
Expand Down