-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the assumption on Language being found and understood #1741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just these minor grammar and consistency issues for your consideration. Will approve when addressed.
@daniel-montalvo All these are about existing assumptions that are not touched by this PR. As much as I agree the changes are needed, I also think that we shouldn't do them as part of this PR in order to keep things focused (the PR is already touching a lot of rules, so I'd prefer keeping it focused on doing one thing). |
Fair enough. Let's then go ahead with as-is and keep the others for later. |
Waiting for w3c/wcag-act#521 to be published before merging this one. Publishing the input aspect might be delayed until #1783 is solved. |
The new version of the Input aspects has been published. |
All rules with Language as input aspect had an assumption about it being determined and understood.
This assumption is moved to the Input aspects document (w3c/wcag-act#521 even though it seems to not be published yet 🤔 ) So we can remove it from the individual rules.
This should probably not be merged before the change in input aspects got published.
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review (moving an assumption to a shared document).
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve