Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the assumption on Language being found and understood #1741

Merged
merged 7 commits into from Jul 12, 2022

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Nov 4, 2021

All rules with Language as input aspect had an assumption about it being determined and understood.
This assumption is moved to the Input aspects document (w3c/wcag-act#521 even though it seems to not be published yet 🤔 ) So we can remove it from the individual rules.

This should probably not be merged before the change in input aspects got published.

Closes issue(s):

  • N/A

Need for Call for Review:
This will require a 1 week Call for Review (moving an assumption to a shared document).


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Nov 4, 2021
@Jym77 Jym77 self-assigned this Nov 4, 2021
Copy link
Collaborator

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just these minor grammar and consistency issues for your consideration. Will approve when addressed.

_rules/heading-descriptive-b49b2e.md Show resolved Hide resolved
_rules/video-only-audio-track-d7ba54.md Show resolved Hide resolved
_rules/video-only-description-track-ac7dc6.md Show resolved Hide resolved
_rules/video-only-transcript-ee13b5.md Show resolved Hide resolved
@Jym77
Copy link
Collaborator Author

Jym77 commented Nov 15, 2021

@daniel-montalvo All these are about existing assumptions that are not touched by this PR. As much as I agree the changes are needed, I also think that we shouldn't do them as part of this PR in order to keep things focused (the PR is already touching a lot of rules, so I'd prefer keeping it focused on doing one thing).

@daniel-montalvo
Copy link
Collaborator

@daniel-montalvo All these are about existing assumptions that are not touched by this PR. As much as I agree the changes are needed, I also think that we shouldn't do them as part of this PR in order to keep things focused (the PR is already touching a lot of rules, so I'd prefer keeping it focused on doing one thing).

Fair enough. Let's then go ahead with as-is and keep the others for later.

@Jym77
Copy link
Collaborator Author

Jym77 commented Jan 27, 2022

Waiting for w3c/wcag-act#521 to be published before merging this one.
It is currently in the Editor's draft version, but not in the published one.

Publishing the input aspect might be delayed until #1783 is solved.

@Jym77
Copy link
Collaborator Author

Jym77 commented Jul 12, 2022

The new version of the Input aspects has been published.
Merging this.

@Jym77 Jym77 merged commit 67b3bdf into develop Jul 12, 2022
@Jym77 Jym77 deleted the remove-lang-assumption branch July 12, 2022 13:33
@Jym77 Jym77 mentioned this pull request Jul 12, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewers wanted Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants