Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete valid: Replace "last" by "next" in expectation #2027

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Feb 7, 2023

When adding webauthn as 5th item, we kept the "last token" in the 3rd item. But this actually refers to the 4th item and should therefore be "next".

I think this do not need a Call for Review since it is a simple correction.

<< Describe the changes >>

Closes issue(s):

  • N/A

Need for Call for Review:
This will require a 1 week Call for Review (fixing a typo in expectation)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

When adding `webauthn` as 5th item, we kept the "**last** token" in the 3rd item. But this actually refers to the 4th item and should therefore be "next".
@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Feb 7, 2023
@Jym77 Jym77 self-assigned this Feb 7, 2023
@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Feb 16, 2023
@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 16, 2023

Call for review ends on February 23rd.

@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 23, 2023

Call for review has ended. Merging.

@Jym77 Jym77 merged commit 9bad856 into develop Feb 23, 2023
@Jym77 Jym77 deleted the autocomplete-valid-fix-expectation branch February 23, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants